fix(ci): enable ICMP tests on Linux and fix gotestfmt on macOS/Windows#1602
Closed
mannie-exe wants to merge 2 commits intocloudflare:masterfrom
Closed
fix(ci): enable ICMP tests on Linux and fix gotestfmt on macOS/Windows#1602mannie-exe wants to merge 2 commits intocloudflare:masterfrom
mannie-exe wants to merge 2 commits intocloudflare:masterfrom
Conversation
mannie-exe
changed the title
mannie-exe
force-pushed
the
fix/ci-workflow
branch
2 times, most recently
from
ad4d7fa to
fae2785
Compare
Author
|
Hey there sorry I had no time to follow-up on this, I wanted to check-in and ask if these changes were needed and if I should make any changes: 649705d#diff-a54ff182c7e8acf56acfd6e4b9c3ff41e2c41a31c9b211b2deb9df75d9a478f9R203 I can close this otherwise |
mannie-exe
force-pushed
the
fix/ci-workflow
branch
from
fae2785 to
139a344
Compare
- Add upstream sync workflow (weekly Monday 6am UTC, ff-only + rebase) - Add Docker publish workflow (tag v*-h2c* → ghcr.io, Trivy scan) - Add CodeQL analysis workflow for Go - Add Dependabot config for Go modules and GitHub Actions - Update check.yaml: Go 1.24 via go-version-file, actions to v6 - Remove semgrep.yml (requires Cloudflare private server)
mannie-exe
force-pushed
the
fix/ci-workflow
branch
from
139a344 to
8850297
Compare
Contributor
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I didn't see any issues for the CI/CD failures, so I'm not really sure if this is needed work, but I did get them working on my fork and wanted to share in case it's needed.